[
https://issues.apache.org/jira/browse/FLINK-2480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14725151#comment-14725151
]
ASF GitHub Bot commented on FLINK-2480:
---------------------------------------
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1073#issuecomment-136667496
@HuangWHWHW
I think this test and also the class `PrintSinkFunctionTest` needs some
more improvement. Here are a few comments:
- Exception during `open()` should not be caught, but should fail the
test. This happens at multiple points in the code.
- The test contains a class that starts with a lower case letter, which
is against the Java style rules.
- The test as a whole extends `RichSinkFunction` which is not necessary
and seems strange.
- The mock print stream overwrites only one `println()` function, which
makes it susceptible to changes in the sink. It is better to use a regular
`PrintStream` that prints to a `StringWriter` to collect all contents.
> Improving tests coverage for org.apache.flink.streaming.api
> -----------------------------------------------------------
>
> Key: FLINK-2480
> URL: https://issues.apache.org/jira/browse/FLINK-2480
> Project: Flink
> Issue Type: Test
> Components: Streaming
> Affects Versions: 0.10
> Reporter: Huang Wei
> Fix For: 0.10
>
> Original Estimate: 504h
> Remaining Estimate: 504h
>
> The streaming API is quite a bit newer than the other code so it is not that
> well covered with tests.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
