Matrix42 commented on issue #8011: [FLINK-11958][on-yarn] fix flink on windows 
yarn deploy failed
URL: https://github.com/apache/flink/pull/8011#issuecomment-474666240
 
 
   > Apart from `AbstractYarnClusterDescriptor`, 
[`BootstrapTools`](https://github.com/apache/flink/blob/master/flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/BootstrapTools.java#L424)
 also has such kind of hard-coded java command to start task manager. Are you 
sure the Flink job could be launched well on Windows even without changes to 
`BootstrapTools`?
   > Waht's more, how to verify this patch seems a problem, would you please 
paste some pictures before and after your changes so that YARN could deploy 
Flink job well.
   
   I just find this bug on I start a cluster on windows yarn, I haven't submit 
a job yet, one PR can only solve on problem, I will reappear the problem of 
running a job and start a new PR,I will past some pictures of  before and after 
my changes ,thanks for your review.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to