[ 
https://issues.apache.org/jira/browse/FLINK-2490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14725336#comment-14725336
 ] 

ASF GitHub Bot commented on FLINK-2490:
---------------------------------------

Github user HuangWHWHW commented on a diff in the pull request:

    https://github.com/apache/flink/pull/992#discussion_r38414236
  
    --- Diff: 
flink-staging/flink-streaming/flink-streaming-core/src/main/java/org/apache/flink/streaming/api/functions/source/SocketTextStreamFunction.java
 ---
    @@ -42,11 +42,13 @@
        private boolean retryForever;
        private Socket socket;
        private static final int CONNECTION_TIMEOUT_TIME = 0;
    -   private static final int CONNECTION_RETRY_SLEEP = 1000;
    +   static int CONNECTION_RETRY_SLEEP = 1000;
    +   protected long retries;
     
        private volatile boolean isRunning;
     
        public SocketTextStreamFunction(String hostname, int port, char 
delimiter, long maxRetry) {
    +           this.retries = 0;
    --- End diff --
    
    Hi,
    I removed this in my new commit.
    Otherwise why doesn`t the CI run?
    This happen in all of my new commits.


> Remove unwanted boolean check in function 
> SocketTextStreamFunction.streamFromSocket
> -----------------------------------------------------------------------------------
>
>                 Key: FLINK-2490
>                 URL: https://issues.apache.org/jira/browse/FLINK-2490
>             Project: Flink
>          Issue Type: Bug
>          Components: Streaming
>    Affects Versions: 0.10
>            Reporter: Huang Wei
>            Priority: Minor
>             Fix For: 0.10
>
>   Original Estimate: 168h
>  Remaining Estimate: 168h
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to