[GitHub] [flink] vthinkxie commented on issue #8016: [FLINK-10705][web]: Rework Flink Web Dashboard

[GitBox]

vthinkxie commented on issue #8016: [FLINK-10705][web]: Rework Flink Web 
Dashboard
URL: https://github.com/apache/flink/pull/8016#issuecomment-474846099
 
 
   Hi @rmetzger 
   Thanks a lot for your comments!
   
   > Problems I encountered:
   > 
   > * Scrolling in this area I marked blue leads to zooming. I understand why 
that is, but it was not very intuitive for me as a user. Do you have any ideas 
how to improve this behavior?
   > 
   > <img alt="Screenshot 2019-03-20 14 28 45" width="2000" 
src="https://user-images.githubusercontent.com/89049/54687718-8855c280-4b1c-11e9-8ea3-f227b5ee3825.png";>
   > 
   
   
   
   The zoom behavior can be disabled by default, I will update this part later 
:)
   
   
   
   
   > * Starting a job with invalid parameters leads to silent errors (they are 
not reported back to the user)
   > 
   > <img alt="Screenshot 2019-03-20 14 32 49" width="1546" 
src="https://user-images.githubusercontent.com/89049/54687950-0b771880-4b1d-11e9-95e7-7b2ded4800d6.png";>
   > 
   
   
   
   The error message will display the right top, all error messages from the 
server will display in the right top, as you mentioned in the last question.
   
   
   
   > Open questions:
   > 
   > 1. I assume the old interface has been removed in this PR?
   >    (Your first PR had the option to choose between the old UI (`/` and the 
new UI `/new`)).
   >    I'm undecided whether it makes sense to go with this dual approach.
   >    If we keep the old one, I fear that the new UI won't be used. Going 
with the new thing might be "risky", if something breaks.
   
   
   Yes, I remove the old UI because it will be harder to maintain both the old 
and the new one at the same time, and it will become more complex if anyone 
want to add some features to the web.
   I think the new UI has covers all features now, If I miss or breaks 
something, please let me know :)
   
   
   > 2. What are the "Messages" at the top for?
   
   
   It is an error message collector, any error message return from the server 
will display in the box now, not only when user submit a job.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services