azagrebin commented on a change in pull request #7807: [FLINK-11723][network] Remove KvState related components from Network… URL: https://github.com/apache/flink/pull/7807#discussion_r267378917
########## File path: flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/KvStateService.java ########## @@ -0,0 +1,172 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.runtime.taskexecutor; + +import org.apache.flink.api.common.JobID; +import org.apache.flink.queryablestate.network.stats.DisabledKvStateRequestStats; +import org.apache.flink.runtime.jobgraph.JobVertexID; +import org.apache.flink.runtime.query.KvStateClientProxy; +import org.apache.flink.runtime.query.KvStateRegistry; +import org.apache.flink.runtime.query.KvStateServer; +import org.apache.flink.runtime.query.QueryableStateUtils; +import org.apache.flink.runtime.query.TaskKvStateRegistry; +import org.apache.flink.runtime.state.internal.InternalKvState; +import org.apache.flink.util.Preconditions; + +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +/** + * KvState related components of each {@link TaskExecutor} instance. This service can + * create the kvState registration for a single task. + */ +public class KvStateService { + private static final Logger LOG = LoggerFactory.getLogger(KvStateService.class); + + /** Registry for {@link InternalKvState} instances. */ + private final KvStateRegistry kvStateRegistry; + + /** Server for {@link InternalKvState} requests. */ + private KvStateServer kvStateServer; + + /** Proxy for the queryable state client. */ + private KvStateClientProxy kvStateClientProxy; + + KvStateService(KvStateRegistry kvStateRegistry, KvStateServer kvStateServer, KvStateClientProxy kvStateClientProxy) { + this.kvStateRegistry = Preconditions.checkNotNull(kvStateRegistry); + this.kvStateServer = kvStateServer; + this.kvStateClientProxy = kvStateClientProxy; + } + + // -------------------------------------------------------------------------------------------- + // Getter/Setter + // -------------------------------------------------------------------------------------------- + + public KvStateRegistry getKvStateRegistry() { + return kvStateRegistry; + } + + public KvStateServer getKvStateServer() { + return kvStateServer; + } + + public KvStateClientProxy getKvStateClientProxy() { + return kvStateClientProxy; + } + + public TaskKvStateRegistry createKvStateTaskRegistry(JobID jobId, JobVertexID jobVertexId) { + return kvStateRegistry.createTaskRegistry(jobId, jobVertexId); + } + + // -------------------------------------------------------------------------------------------- + // Start and shut down methods + // -------------------------------------------------------------------------------------------- + + public void start() { Review comment: Previously start and shutdown methods were synchronised by lock in `NetworkEnviroment`. It seems KV objects are independent from connectionManager. Do we need the similar lock in start and shutdown in `KvStateService` to make them mutually exclusive as in `NetworkEnviroment`? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
