[ https://issues.apache.org/jira/browse/FLINK-11153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16799522#comment-16799522 ]
vinoyang edited comment on FLINK-11153 at 3/23/19 4:34 AM: ----------------------------------------------------------- +1, I agree [~twalthr] 's idea. I have just had a look at the classes in sca package, most of those classes are not used outside of the sca package. So we can remove all the whole sca package. cc [~Zentol] and [~gjy] update: Just found two use cases in {{UdfOperatorUtils#analyzeSingleInputUdf}} and {{UdfOperatorUtils#analyzeDualInputUdf}} Considering there are many classes (include dependency and test classes in different places), I suggest that we can create an umbrella issue to do the cleanup work. I can help to do this work. What do you think? was (Author: yanghua): +1, I agree [~twalthr] 's idea. I have just had a look at the classes in sca package, most of those classes are not used outside of the sca package. So we can remove all the whole sca package. cc [~Zentol] and [~gjy] update: Just found two use cases in {{UdfOperatorUtils#analyzeSingleInputUdf}} and {{UdfOperatorUtils#analyzeDualInputUdf}} > Remove UdfAnalyzer > ------------------ > > Key: FLINK-11153 > URL: https://issues.apache.org/jira/browse/FLINK-11153 > Project: Flink > Issue Type: Sub-task > Components: API / DataStream, Tests > Affects Versions: 1.8.0 > Reporter: Gary Yao > Assignee: vinoyang > Priority: Major > > {noformat} > org.apache.flink.api.java.sca.CodeAnalyzerException: Exception occurred > during code analysis. > at > org.apache.flink.api.java.sca.UdfAnalyzer.analyze(UdfAnalyzer.java:341) > at > org.apache.flink.api.java.sca.UdfAnalyzerTest.compareAnalyzerResultWithAnnotationsSingleInputWithKeys(UdfAnalyzerTest.java:1339) > at > org.apache.flink.api.java.sca.UdfAnalyzerTest.compareAnalyzerResultWithAnnotationsSingleInput(UdfAnalyzerTest.java:1322) > at > org.apache.flink.api.java.sca.UdfAnalyzerTest.testForwardWithArrayModification(UdfAnalyzerTest.java:695) > at > java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.base/java.lang.reflect.Method.invoke(Method.java:564) > at > org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50) > at > org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) > at > org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47) > at > org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) > at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325) > at > org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78) > at > org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57) > at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290) > at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71) > at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288) > at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58) > at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268) > at org.junit.runners.ParentRunner.run(ParentRunner.java:363) > at org.junit.runner.JUnitCore.run(JUnitCore.java:137) > at > com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:68) > at > com.intellij.rt.execution.junit.IdeaTestRunner$Repeater.startRunnerWithArgs(IdeaTestRunner.java:47) > at > com.intellij.rt.execution.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:242) > at > com.intellij.rt.execution.junit.JUnitStarter.main(JUnitStarter.java:70) > Caused by: java.lang.IllegalArgumentException > at > org.apache.flink.shaded.asm5.org.objectweb.asm.ClassReader.<init>(Unknown > Source) > at > org.apache.flink.shaded.asm5.org.objectweb.asm.ClassReader.<init>(Unknown > Source) > at > org.apache.flink.shaded.asm5.org.objectweb.asm.ClassReader.<init>(Unknown > Source) > at > org.apache.flink.api.java.sca.UdfAnalyzerUtils.findMethodNode(UdfAnalyzerUtils.java:131) > at > org.apache.flink.api.java.sca.UdfAnalyzerUtils.findMethodNode(UdfAnalyzerUtils.java:115) > at > org.apache.flink.api.java.sca.UdfAnalyzer.analyze(UdfAnalyzer.java:290) > ... 25 more > {noformat} -- This message was sent by Atlassian JIRA (v7.6.3#76005)