zhijiangW commented on a change in pull request #7911: [FLINK-11082][network]
Fix the logic of getting backlog in sub partition
URL: https://github.com/apache/flink/pull/7911#discussion_r268972992
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/ResultSubpartition.java
##########
@@ -115,52 +115,62 @@ protected Throwable getFailureCause() {
public abstract boolean isReleased();
+ public abstract boolean isFinished();
Review comment:
The access modifiers for these two methods could be narrowed down to
`protected`. And I agree with ignoring the unsafe suffixes for them after
changing to `protected`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
