tillrohrmann opened a new pull request #8060: [FLINK-12021] Deploy execution in topological sorted order URL: https://github.com/apache/flink/pull/8060 ## What is the purpose of the change Due to changes how the slot futures are completed and due to the fact that the ResultConjunctFuture does not maintain the order in which the futures were specified, it could happen that executions were not deployed in topological order. This commit fixes this problem by changing the ResultConjunctFuture so that it maintains the order of the specified futures in its result collection. This also fixes a performance regression when deploying tasks since deploying tasks in non-topological order can lead to additional result partition lookups. ## Verifying this change - Added `ExecutionGraphDeploymentTest#testExecutionGraphIsDeployedInTopologicalOrder` and `ConjunctFutureTest#testConjunctFutureCompletion`. ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (no) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no) - The serializers: (no) - The runtime per-record code paths (performance sensitive): (no) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes) - The S3 file system connector: (no) ## Documentation - Does this pull request introduce a new feature? (no) - If yes, how is the feature documented? (not applicable)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
