pnowojski commented on a change in pull request #7959: [FLINK-11876] Introduce new InputSelectable, BoundedOneInput and BoundedMultiInput interfaces URL: https://github.com/apache/flink/pull/7959#discussion_r269533815
########## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/InputSelection.java ########## @@ -0,0 +1,102 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.streaming.api.operators; + +import org.apache.flink.annotation.PublicEvolving; + +/** + * Describe the input selection that operators want to get the next record. + */ +@PublicEvolving +public final class InputSelection { + + /** + * The {@code InputSelection} instance which indicates to select all inputs. + */ + public static final InputSelection ALL = new InputSelectionBuilder().select(-1).build(); + + /** + * The {@code InputSelection} instance which indicates to select the first input. + */ + public static final InputSelection FIRST = new InputSelectionBuilder().select(1).build(); + + /** + * The {@code InputSelection} instance which indicates to select the second input. + */ + public static final InputSelection SECOND = new InputSelectionBuilder().select(2).build(); + + private final long inputMask; + + private InputSelection(long inputMask) { + this.inputMask = inputMask; + } + + public long getInputMask() { + return inputMask; + } + + @Override + public boolean equals(Object o) { + if (this == o) { + return true; + } + if (o == null || getClass() != o.getClass()) { + return false; + } + + InputSelection that = (InputSelection) o; + return inputMask == that.inputMask; + } + + @Override + public String toString() { + return String.valueOf(inputMask); + } + + /** + * Utility class for creating {@link InputSelection}. + */ + public static final class InputSelectionBuilder { Review comment: nit: the usual convention is to have the static inner builder class just named `Builder`, without the redundant `InputSelection` prefix. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
