zhijiangW commented on a change in pull request #8095: [FLINK-12078][network] Abstract TaskEventPublisher interface for simplifying NetworkEnvironment URL: https://github.com/apache/flink/pull/8095#discussion_r271118936
########## File path: flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/Task.java ########## @@ -386,6 +391,8 @@ public Task( ioManager, desc.sendScheduleOrUpdateConsumersMessage()); + taskEventDispatcher.registerPartition(partitionId); Review comment: I tried to save a loop to put with partition creation. It actually seems more reasonable to match with finally as before. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services