sunjincheng121 commented on a change in pull request #8087: [FLINK-12029][table] Add column operations for TableApi URL: https://github.com/apache/flink/pull/8087#discussion_r271221161
########## File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/expressions/BuiltInFunctionDefinitions.java ########## @@ -319,6 +319,14 @@ public static final FunctionDefinition CURRENT_ROW = new FunctionDefinition("currentRow", OTHER_FUNCTION); + // columns + public static final FunctionDefinition COLUMNS = + new FunctionDefinition("columns", OTHER_FUNCTION); + public static final FunctionDefinition COLUMNS_RANGE = + new FunctionDefinition("columnsRange", OTHER_FUNCTION); + public static final FunctionDefinition COLUMNS_INVERSE_SELECTION = + new FunctionDefinition("columnsInverseSelection", OTHER_FUNCTION); + Review comment: And I think we can try to remove `COLUMNS_INVERSE_SELECTION` and using `MINUS_PREFIX`. What do you think? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services