zentol commented on a change in pull request #8052:
[FLINK-11458][checkpointing, rest] Add TERMINATE/SUSPEND Job with Savepoint
(FLIP-34)
URL: https://github.com/apache/flink/pull/8052#discussion_r271693746
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/TerminationModeQueryParameter.java
##########
@@ -49,7 +49,7 @@ public String getDescription() {
}
/**
- * Supported termination modes.
+ * Supported termination modes. todo this will be removed
Review comment:
should be retained since the existing cancel functionality remains
accessible. In case of stop, as discussed offline, we should return a
meaningful error to the user about this operation being no longer supported
along with an error code that is not 404 (not found); possibly 410 (permanently
removed) or 501 (not implemented).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
