xuefuz commented on a change in pull request #8007: [FLINK-11474][table] Add ReadableCatalog, ReadableWritableCatalog, and other … URL: https://github.com/apache/flink/pull/8007#discussion_r273242001
########## File path: flink-table/flink-table-common/src/test/java/org/apache/flink/table/catalog/GenericInMemoryCatalogTest.java ########## @@ -0,0 +1,581 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.table.catalog; + +import org.apache.flink.api.common.typeinfo.BasicTypeInfo; +import org.apache.flink.api.common.typeinfo.TypeInformation; +import org.apache.flink.table.api.TableSchema; +import org.apache.flink.table.catalog.exceptions.DatabaseAlreadyExistException; +import org.apache.flink.table.catalog.exceptions.DatabaseNotEmptyException; +import org.apache.flink.table.catalog.exceptions.DatabaseNotExistException; +import org.apache.flink.table.catalog.exceptions.TableAlreadyExistException; +import org.apache.flink.table.catalog.exceptions.TableNotExistException; + +import org.junit.After; +import org.junit.AfterClass; +import org.junit.Before; +import org.junit.Rule; +import org.junit.Test; +import org.junit.rules.ExpectedException; + +import java.io.IOException; +import java.util.Arrays; +import java.util.HashMap; +import java.util.HashSet; +import java.util.List; +import java.util.Map; + +import static org.junit.Assert.assertEquals; +import static org.junit.Assert.assertFalse; +import static org.junit.Assert.assertNotEquals; +import static org.junit.Assert.assertTrue; + +/** + * Test for GenericInMemoryCatalog. + */ +public class GenericInMemoryCatalogTest { + private static final String IS_STREAMING = "is_streaming"; + + private final String testCatalogName = "test-catalog"; + private final String db1 = "db1"; + private final String db2 = "db2"; + + private final String t1 = "t1"; + private final String t2 = "t2"; + private final ObjectPath path1 = new ObjectPath(db1, t1); + private final ObjectPath path2 = new ObjectPath(db2, t2); + private final ObjectPath path3 = new ObjectPath(db1, t2); + private final ObjectPath nonExistDbPath = ObjectPath.fromString("non.exist"); + private final ObjectPath nonExistObjectPath = ObjectPath.fromString("db1.nonexist"); + + private static final String TEST_COMMENT = "test comment"; + + private static ReadableWritableCatalog catalog; + + @Before + public void setUp() { + catalog = new GenericInMemoryCatalog(db1); + } + + @Rule + public ExpectedException exception = ExpectedException.none(); + + @After + public void close() { + if (catalog.tableExists(path1)) { + catalog.dropTable(path1, true); + } + if (catalog.tableExists(path2)) { + catalog.dropTable(path2, true); + } + if (catalog.tableExists(path3)) { + catalog.dropTable(path3, true); + } + if (catalog.databaseExists(db1)) { + catalog.dropDatabase(db1, true); + } + if (catalog.databaseExists(db2)) { + catalog.dropDatabase(db2, true); + } + } + + @AfterClass Review comment: Catalog is created and discarded after each test. Thus, the @AfterClass is not needed. Instead, I put open() and close() in @before and @After. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
