sunjincheng121 commented on a change in pull request #8007: [FLINK-11474][table] Add ReadableCatalog, ReadableWritableCatalog, and other … URL: https://github.com/apache/flink/pull/8007#discussion_r273762199
########## File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/catalog/GenericCatalogTable.java ########## @@ -0,0 +1,73 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.table.catalog; + +import org.apache.flink.table.api.TableSchema; +import org.apache.flink.table.plan.stats.TableStats; + +import java.util.Map; + +/** + * A generic catalog table implementation. + */ +public class GenericCatalogTable implements CatalogTable { + // Schema of the table (column names and types) + private final TableSchema tableSchema; + // Properties of the table + private final Map<String, String> properties; + // Statistics of the table + private TableStats tableStats = null; Review comment: I meant that we should add `final`. due to we only init it in the construct method. right? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
