[ https://issues.apache.org/jira/browse/FLINK-3685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16814379#comment-16814379 ]
Ji Liu commented on FLINK-3685: ------------------------------- Since this problem is fixed in [FLINK-3856|https://issues.apache.org/jira/browse/FLINK-3856], so this issue can be closed. > Logical error in code for DateSerializer deserialize with reuse > --------------------------------------------------------------- > > Key: FLINK-3685 > URL: https://issues.apache.org/jira/browse/FLINK-3685 > Project: Flink > Issue Type: Bug > Components: API / Type Serialization System > Affects Versions: 1.0.0 > Reporter: ZhengBowen > Priority: Major > > There is a logical error in the following function in DateSerializer.java > when source read '-1' > function is: > {code} > public Date deserialize(Date reuse, DataInputView source) throws IOException { > long v = source.readLong(); > if(v == -1L) { > return null; > } > reuse.setTime(v); > return reuse; > } > {code} > when call this function for first time, if return null, then 'reuse' will be > set null by caller; > when call this function for second time,if 'v!=-1' ,reuse.setTime(v) will > throw NPE. -- This message was sent by Atlassian JIRA (v7.6.3#76005)