dawidwys commented on a change in pull request #8050: [FLINK-11067][table]
Convert TableEnvironments to interfaces
URL: https://github.com/apache/flink/pull/8050#discussion_r274383474
##########
File path:
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/calcite/DefaultPlannerConfig.scala
##########
@@ -262,17 +257,9 @@ class CalciteConfigBuilder {
}
/**
- * Calcite configuration for defining a custom Calcite configuration for
Table and SQL API.
- *
- * @deprecated This class will be removed temporarily while the API is
uncoupled
- * from Calcite. An alternative might be provided in the future.
See FLINK-11728
- * for more information.
+ * Default Planner configuration for defining a custom planner configuration
for Table and SQL API.
*/
-@Deprecated
-@deprecated(
- "This method will be removed temporarily while the API is uncoupled from
Calcite.",
- "1.8.0")
-trait CalciteConfig {
+trait DefaultPlannerConfig extends PlannerConfig {
Review comment:
I think we can get rid of this trait. We can merge the
`DefaultPlannerConfig` with `DefaultPlannerConfigImpl`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
