Github user mjsax commented on the pull request:

    https://github.com/apache/flink/pull/1046#issuecomment-137742282
  
    I have just a quick look over it, and so far it like it. Two things are 
open to be discussed. I not sure it the change to `ConfigConstants` in a good 
choice. Would it be feasible to use `TaskConfiguration` instead of 
`JobConfiguration`. This would make a code cleaner from my point of view.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to