xuefuz commented on a change in pull request #8007: [FLINK-11474][table] Add ReadableCatalog, ReadableWritableCatalog, and other … URL: https://github.com/apache/flink/pull/8007#discussion_r274899236
########## File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/catalog/CatalogDatabase.java ########## @@ -0,0 +1,38 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.table.catalog; + +import java.util.Map; + +/** + * Represents a database object in a catalog. + */ +public interface CatalogDatabase { Review comment: > Hi @sunjincheng121 , @xuefuz , @bowenli86 > > Regarding to the `listTables()`, I'm fine with current approach that `listTables` returns tables and views if you all prefer it. I don't have a strong opinion on this. > > Regarding moving to the mailing list, my initial intention is involving more people into the discussion when we have diverging opinions on API, but it seems that we have a consensus on this now. I agree with @sunjincheng121 that if we think the API change is minor, I think it's fine to keep the discussion in PR. But I would suggest to update the FLIP according to the latest change after the pull request is merged. > > So, I'm +1 to merge this after Dawid's comments addressed. Yes, I will update the FLIP to reflect what we have agreed upon. Thanks. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
