[
https://issues.apache.org/jira/browse/FLINK-2525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14730868#comment-14730868
]
ASF GitHub Bot commented on FLINK-2525:
---------------------------------------
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1046#issuecomment-137748262
Concerning the changes at the core classes:
- The storm config key is an application specific key and not part of the
system configuration, therefore it should be defined as part of the application
code.
- When returning the JobManager configuration, this should return an
unmodifiable configuration, so the internal config cannot be altered.
- Do you need access to the inner config hashmap? How about storing the
storm specific properties in a key like this:
`InstantiationUtil.writeObjectToConfig(stormProps, config, "STORM_CONF");`
> Add configuration support in Storm-compatibility
> ------------------------------------------------
>
> Key: FLINK-2525
> URL: https://issues.apache.org/jira/browse/FLINK-2525
> Project: Flink
> Issue Type: New Feature
> Components: Storm Compatibility
> Reporter: fangfengbin
> Assignee: fangfengbin
>
> Spouts and Bolt are initialized by a call to `Spout.open(...)` and
> `Bolt.prepare()`, respectively. Both methods have a config `Map` as first
> parameter. This map is currently not populated. Thus, Spouts and Bolts cannot
> be configure with user defined parameters. In order to support this feature,
> spout and bolt wrapper classes need to be extended to create a proper `Map`
> object. Furthermore, the clients need to be extended to take a `Map`,
> translate it into a Flink `Configuration` that is forwarded to the wrappers
> for proper initialization of the map.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
