StefanRRichter commented on a change in pull request #7571: [FLINK-10724] 
Refactor failure handling in check point coordinator
URL: https://github.com/apache/flink/pull/7571#discussion_r275711871
 
 

 ##########
 File path: 
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinator.java
 ##########
 @@ -666,10 +671,11 @@ else if (!props.forceCheckpoint()) {
         * Receives a {@link DeclineCheckpoint} message for a pending 
checkpoint.
         *
         * @param message Checkpoint decline from the task manager
+        * @return <code>true</code> if should fail the job
         */
-       public void receiveDeclineMessage(DeclineCheckpoint message) {
+       public boolean receiveDeclineMessage(DeclineCheckpoint message) {
 
 Review comment:
   @yanghua thanks, I will take another look!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to