godfreyhe commented on issue #8176: [FLINK-12192] [table-planner-blink] Add support for generating optimized logical plan for grouping sets and distinct aggregate URL: https://github.com/apache/flink/pull/8176#issuecomment-483665247 > > extends AggregateExpandDistinctAggregatesRule to fix some bugs > > Would you please explaining a bit more about the bugs? Bugs and unsupported cases include 1. Throws an exception if an aggregate contains both approximate distinct aggregate call and accurate distinct aggregate call. 2. Excludes non-simple aggregate(e.g. CUBE, ROLLUP). 3. Fix bug: Some aggregate functions (e.g. COUNT) has a non-null result even without any input. 4. Fix bug: Add filter argument into rewritten aggregateCall if its filter argument is not -1. which are also recorded in the class comments.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
