dawidwys commented on a change in pull request #8050: [FLINK-11067][table]
Convert TableEnvironments to interfaces
URL: https://github.com/apache/flink/pull/8050#discussion_r276216129
##########
File path:
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/api/tableImpl.scala
##########
@@ -393,7 +395,7 @@ class TableImpl(
override def window(overWindows: OverWindow*): OverWindowedTable = {
- if (tableEnv.isInstanceOf[BatchTableEnvironment]) {
+ if (tableEnv.isInstanceOf[BatchTableEnvImpl]) {
Review comment:
What about the java version?
I think it applies to all places we check if it is Batch or Stream.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
