zentol commented on a change in pull request #8199: [FLINK-11955] Modify build
to move filesystems from lib to plugins folder
URL: https://github.com/apache/flink/pull/8199#discussion_r276357181
##########
File path: flink-dist/pom.xml
##########
@@ -140,19 +140,54 @@ under the License.
</exclusions>
</dependency>
+ <!--
+ The following dependencies are packaged in 'plugin/'
+ The scope of these dependencies needs to be 'provided'
so that
+ they are not included into the 'flink-dist' uber jar.
+ -->
<!-- Default file system support. The Hadoop and MapR
dependencies -->
<!-- are optional, so not being added to the dist jar
-->
<dependency>
<groupId>org.apache.flink</groupId>
<artifactId>flink-hadoop-fs</artifactId>
<version>${project.version}</version>
+ <scope>provided</scope>
Review comment:
I don't believe the merge order to be relevant here. None of the other
subtasks are about re-introducing the hadoop/mapr compatibility code into
flink-dist or having them on the classpath by default; as such my point still
stands.
Conceptually I'm in favor of having these in the plugin directory as an
opt-in feature, but nevertheless, we may break plenty of setups.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
