bowenli86 commented on a change in pull request #8222: [FLINK-11518]
[SQL/TABLE] Add partition related catalog APIs and implement them in
GenericInMemoryCatalog
URL: https://github.com/apache/flink/pull/8222#discussion_r276918514
##########
File path:
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/catalog/GenericCatalogTable.java
##########
@@ -33,30 +35,53 @@
public class GenericCatalogTable implements CatalogTable {
// Schema of the table (column names and types)
private final TableSchema tableSchema;
- // Properties of the table
- private final Map<String, String> properties;
// Statistics of the table
private final TableStats tableStats;
+ // Partition keys if this is a partitioned table. It's an empty set if
the table is not partitioned
+ private final Set<String> partitionKeys;
Review comment:
You are right, this should be a LinkedHashSet to preserve order and
guarantee uniqueness. I used LinkedHashSet in test and forgot to update here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
