hequn8128 commented on a change in pull request #8050: [FLINK-11067][table] Convert TableEnvironments to interfaces URL: https://github.com/apache/flink/pull/8050#discussion_r277711031
########## File path: flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/plan/nodes/dataset/DataSetValues.scala ########## @@ -67,7 +67,7 @@ class DataSetValues( } override def translateToPlan( - tableEnv: BatchTableEnvironment, + tableEnv: BatchTableEnvImpl, Review comment: Totally agree with you. Most of the places only use `tableEnv.getConfig`. However, `tableEnv.execEnv` is used in `DataSetValues`, `DataStreamValues` and `StreamTableSourceScan`. Also `tableEnv.getRelBuilder` is used in `StreamTableSourceScan`. Maybe we can simplify this a bit or just simply put them into the `PlannerContext`. Btw, how about fixing this in another PR. We may need some more discussions. And let this PR focus on the tableEnv interface. What do you think? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
