rmetzger commented on issue #8303: [FLINK-12343]add file replication config for 
yarn configuration
URL: https://github.com/apache/flink/pull/8303#issuecomment-487632182
 
 
   I tend to disagree. I think the problem is well defined, the configuration 
parameter name is okay (not great) and the idea of how to solve the problem is 
also good.
   However, there are some issues with the implementation approach: The 
replication factor is set with each call of the utility. I would rather set it 
once globally.
   Secondly, the code seems to use a default value (3), potentially ignoring a 
global configuration param set by HDFS.
   
   @flinkbot approve description

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to