azagrebin commented on a change in pull request #8310: [FLINK-12331][network] 
Introduce partition/gate setup to decouple task registration with 
NetworkEnvironment
URL: https://github.com/apache/flink/pull/8310#discussion_r279410838
 
 

 ##########
 File path: 
flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/Task.java
 ##########
 @@ -599,20 +599,23 @@ else if (current == ExecutionState.CANCELING) {
                        }
 
                        // 
----------------------------------------------------------------
-                       // register the task with the network stack
+                       // setup partitions and gates before task running
 
 Review comment:
   Move to separate method `Task.setupPartitionsAndGates()`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to