zhijiangW commented on a change in pull request #8310: [FLINK-12331][network]
Introduce partition/gate setup to decouple task registration with
NetworkEnvironment
URL: https://github.com/apache/flink/pull/8310#discussion_r279447428
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/ResultPartition.java
##########
@@ -131,6 +140,9 @@ public ResultPartition(
ResultPartitionType partitionType,
int numberOfSubpartitions,
int numTargetKeyGroups,
+ int networkBuffersPerChannel,
Review comment:
That might be a good idea from the aspect of minimal changes especially for
tests. I would consider and have a try. It actually takes much effort to
refactor the existing tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
