sunjincheng121 commented on a change in pull request #8267: [FLINK-12311][table][python] Add base python framework and Add Scan, Projection, and Filter operator support URL: https://github.com/apache/flink/pull/8267#discussion_r279592971
########## File path: flink-python/setup.py ########## @@ -0,0 +1,63 @@ +################################################################################ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +################################################################################ +from __future__ import print_function + +import os +import sys +from setuptools import setup + +if sys.version_info < (2, 7): + print("Python versions prior to 2.7 are not supported for PyFlink.", + file=sys.stderr) + sys.exit(-1) + +this_directory = os.path.abspath(os.path.dirname(__file__)) +version_file = os.path.join(this_directory, 'pyflink/version.py') + +try: + exec(open(version_file).read()) +except IOError: + print("Failed to load PyFlink version file for packaging. " + + "'%s' not found!" % version_file, + file=sys.stderr) + sys.exit(-1) +VERSION = __version__ # noqa + +with open(os.path.join(this_directory, 'README.md'), encoding='utf-8') as f: Review comment: Dose `encoding='utf-8'` can be pasered in py27? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
