bowenli86 commented on a change in pull request #8314: [FLINK-12365][table] Add
stats related catalog APIs
URL: https://github.com/apache/flink/pull/8314#discussion_r279839941
##########
File path:
flink-table/flink-table-api-java/src/test/java/org/apache/flink/table/catalog/GenericInMemoryCatalogTest.java
##########
@@ -1104,6 +1104,43 @@ public void testDropFunction_FunctionNotExist_ignored()
throws Exception {
catalog.dropDatabase(db1, false);
}
+ // ------ statistics ------
Review comment:
> Well, I think the added test is written differently as others, which gives
such an expression. However, it covers all the added implementation methods, as
you can see. What's missing, though, is some negative test cases, which I will
create a followup JIRA for this.
I think we need to have a consistent style for unit tests in this class,
otherwise it's hard for other developers to figure out the two styles and
extend/modify the testing code
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
