GJL commented on a change in pull request #8233: [FLINK-12227] [runtime] introduce SchedulingStrategy interface URL: https://github.com/apache/flink/pull/8233#discussion_r279787045
########## File path: flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/strategy/SchedulingStrategy.java ########## @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.runtime.scheduler.strategy; + +import org.apache.flink.runtime.execution.ExecutionState; +import org.apache.flink.runtime.executiongraph.Execution; +import org.apache.flink.runtime.executiongraph.IntermediateResultPartition; +import org.apache.flink.runtime.io.network.partition.ResultPartitionID; + +import java.util.Set; + +/** + * Component which encapsulates the scheduling logic. + * It can react to execution state changes and partition consumable events. + * Moreover, it is responsible for resolving task failures. + */ +public interface SchedulingStrategy { + + /** + * Called when the scheduling is started (initial scheduling operation). + */ + void startScheduling(); + + /** + * Called whenever vertices need to be restarted (due to task failure). + * + * @param verticesNeedingRestart The tasks need to be restarted. + */ + void restartTasks(Set<ExecutionVertexID> verticesNeedingRestart); + + /** + * Called whenever an {@link Execution} changes its state. + * + * @param executionVertexId The id of the task. + * @param executionState The new state of the execution. + */ + void onExecutionStateChange(ExecutionVertexID executionVertexId, ExecutionState executionState); + + /** + * Called whenever an {@link IntermediateResultPartition} becomes consumable. + * + * @param executionVertexId The id of the task whoes result partition becomes consumable. Review comment: `@param executionVertexId _The id of the producer._` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
