lamber-ken commented on issue #8254: [FLINK-12219][runtime] Yarn application can't stop when flink job failed in per-job yarn cluste mode URL: https://github.com/apache/flink/pull/8254#issuecomment-488698323 hi, @tillrohrmann, I think your fix is fantastic [tillrohrmann@524ead4](https://github.com/tillrohrmann/flink/commit/524ead44f68ff02d52e8ff561c9e235e5b353123). like the [FLINK-12247](https://github.com/apache/flink/pull/8250), We used flink from 1.2.1 to 1.6.3 and we have been puzzled by this problem for a long time. Because it‘s needs the count of flink job failed attempt up to the max attempt history size, and no error log information that we can find the reason why the flink job failed but the yarn application don't stop in detach mode. May be other users had met the same bug, but they did not mention it or fix it. So I think it's better to log the error information and stop the application like your solution [tillrohrmann@524ead4](https://github.com/tillrohrmann/flink/commit/524ead44f68ff02d52e8ff561c9e235e5b353123). If don't do that, any unexpected exception happens, the yarn application will can not stop again. It will need users to find out the reason, it's hard to users. Best.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
