piyushnarang commented on a change in pull request #8117: [FLINK-12115] 
[filesystems]: Add support for AzureFS
URL: https://github.com/apache/flink/pull/8117#discussion_r280465958
 
 

 ##########
 File path: 
flink-filesystems/flink-azure-fs-hadoop/src/main/java/org/apache/flink/fs/azurefs/AbstractAzureFSFactory.java
 ##########
 @@ -48,6 +55,33 @@ public void configure(Configuration config) {
        public FileSystem create(URI fsUri) throws IOException {
                checkNotNull(fsUri, "passed file system URI object should not 
be null");
                LOG.info("Trying to load and instantiate Azure File System");
-               return new AzureFileSystem(fsUri, flinkConfig);
+               return new HadoopFileSystem(createInitializedAzureFS(fsUri, 
flinkConfig));
+       }
+
+       // uri is of the form: 
wasb(s)://yourcontai...@youraccount.blob.core.windows.net/testDir
+       private org.apache.hadoop.fs.FileSystem createInitializedAzureFS(URI 
fsUri, Configuration flinkConfig) throws IOException {
+               org.apache.hadoop.conf.Configuration hadoopConfig = 
HadoopUtils.getHadoopConfiguration(flinkConfig);
 
 Review comment:
   Updated the review to incorporate this. I've filed: 
https://jira.apache.org/jira/browse/FLINK-12394

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to