dianfu commented on a change in pull request #8311: [FLINK-10976][table] Add
Aggregate operator to Table API
URL: https://github.com/apache/flink/pull/8311#discussion_r281000677
##########
File path:
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/operations/OperationTreeBuilder.scala
##########
@@ -159,6 +159,66 @@ class OperationTreeBuilder(private val tableEnv:
TableEnvImpl) {
aggregateOperationFactory.createAggregate(resolvedGroupings,
resolvedAggregates, child)
}
+ def rowBasedAggregate(
+ groupingExpressions: JList[Expression],
+ aggregate: Expression,
+ child: TableOperation)
+ : TableOperation = {
+ // resolve for java string case, i.e., turn LookupCallExpression to
CallExpression.
+ val resolver = resolverFor(tableCatalog, functionCatalog, child).build
+ val resolvedAggregate = resolveSingleExpression(aggregate, resolver)
Review comment:
use resolveExpression?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
