sunjincheng121 commented on a change in pull request #8347: [FLINK-12326][python] Add basic test framework for python api URL: https://github.com/apache/flink/pull/8347#discussion_r281432761
########## File path: flink-python/pyflink/testing/source_sink_utils.py ########## @@ -0,0 +1,127 @@ +################################################################################ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +################################################################################# + +import glob +import os +import unittest +from py4j.java_gateway import java_import + +from pyflink.find_flink_home import _find_flink_source_root +from pyflink.java_gateway import get_gateway +from pyflink.table import TableSink + + +class TestTableSink(TableSink): + """ + Base class for test table sink. + """ + + _inited = False + + def __init__(self, j_table_sink): + super(TestTableSink, self).__init__(j_table_sink) + + @classmethod + def _ensure_initialized(cls): + if TestTableSink._inited: + return + + FLINK_SOURCE_ROOT_DIR = _find_flink_source_root() + filename_pattern = ( + "flink-table/flink-table-planner/target/" + "flink-table-planner*-tests.jar") + if not glob.glob(os.path.join(FLINK_SOURCE_ROOT_DIR, filename_pattern)): + raise unittest.SkipTest( + "'flink-table-planner*-tests.jar' is not available. Will skip the related tests.") + + gateway = get_gateway() + java_import(gateway.jvm, "org.apache.flink.table.runtime.stream.table.TestAppendSink") + java_import(gateway.jvm, "org.apache.flink.table.runtime.stream.table.TestRetractSink") + java_import(gateway.jvm, "org.apache.flink.table.runtime.stream.table.TestUpsertSink") + java_import(gateway.jvm, "org.apache.flink.table.runtime.stream.table.RowCollector") + + TestTableSink._inited = True + + +class TestAppendSink(TestTableSink): + """ + A test append table sink. + """ + + def __init__(self): + TestTableSink._ensure_initialized() + + gateway = get_gateway() + super(TestAppendSink, self).__init__(gateway.jvm.TestAppendSink()) + + +class TestRetractSink(TestTableSink): + """ + A test retract table sink. + """ + + def __init__(self): + TestTableSink._ensure_initialized() + + gateway = get_gateway() + super(TestRetractSink, self).__init__(gateway.jvm.TestRetractSink()) + + +class TestUpsertSink(TestTableSink): + """ + A test upsert table sink. + """ + + def __init__(self, keys, is_append_only): + TestTableSink._ensure_initialized() + + gateway = get_gateway() + j_keys = gateway.new_array(gateway.jvm.String, len(keys)) + for i in xrange(0, len(keys)): + j_keys[i] = keys[i] + + super(TestUpsertSink, self).__init__(gateway.jvm.TestUpsertSink(j_keys, is_append_only)) + + +def results(): + """ + Retrieves the results from an append table sink. + """ + return retract_results() + + +def retract_results(): + """ + Retrieves the results from a retract table sink. + """ + gateway = get_gateway() + results = gateway.jvm.RowCollector.getAndClearValues() Review comment: Can we remove `results`.? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
