wuchong commented on a change in pull request #8288: [FLINK-12345] [table-planner-blink] Add support for generating optimized logical plan for stream window aggregate URL: https://github.com/apache/flink/pull/8288#discussion_r281448847
########## File path: flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/plan/nodes/physical/stream/StreamExecGroupWindowAggregate.scala ########## @@ -0,0 +1,139 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.table.plan.nodes.physical.stream + +import org.apache.flink.streaming.api.transformations.StreamTransformation +import org.apache.flink.table.api.{StreamTableEnvironment, TableConfigOptions, TableException} +import org.apache.flink.table.calcite.FlinkRelBuilder.NamedWindowProperty +import org.apache.flink.table.dataformat.BaseRow +import org.apache.flink.table.plan.logical._ +import org.apache.flink.table.plan.nodes.exec.{ExecNode, StreamExecNode} +import org.apache.flink.table.plan.util.AggregateUtil.{isRowtimeIndicatorType, isTimeIntervalType} +import org.apache.flink.table.plan.util.{RelExplainUtil, WindowEmitStrategy} + +import org.apache.calcite.plan.{RelOptCluster, RelTraitSet} +import org.apache.calcite.rel.`type`.RelDataType +import org.apache.calcite.rel.core.AggregateCall +import org.apache.calcite.rel.{RelNode, RelWriter, SingleRel} + +import java.util + +import scala.collection.JavaConversions._ + +/** + * Streaming group window aggregate physical node which will be translate to window operator. + * + * If requirements satisfied, it will be translated into minibatch window operator, otherwise, Review comment: The minibatch-window is still in beta in Blink. I think we can support it after 1.9 release. What do you think about removing minibatch-window relative comments and codes? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
