KurtYoung commented on a change in pull request #8294:
[FLINK-12348][table-planner-blink]Use TableConfig in api module to replace
TableConfig in blink-planner module.
URL: https://github.com/apache/flink/pull/8294#discussion_r281447839
##########
File path:
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/api/BatchTableEnvironment.scala
##########
@@ -96,8 +97,9 @@ class BatchTableEnvironment(
private def mergeParameters(): Unit = {
if (streamEnv != null && streamEnv.getConfig != null) {
val parameters = new Configuration()
- if (config != null && config.getConf != null) {
- parameters.addAll(config.getConf)
+ val parametersFromTableConfig = infer(config).getConf
Review comment:
It looks unclear if you import the static method and directly use `infer`
here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
