zhijiangW edited a comment on issue #8242: [FLINK-6227][network] Introduce the 
DataConsumptionException for downstream task failure
URL: https://github.com/apache/flink/pull/8242#issuecomment-490348518
 
 
   Yes, I think we are on the same page now.
   
   I would focus on `b, c` in this PR, and launch separate PRs for the other 
cases future. Especially for `DataConnectionException` we might add the retry 
mechanism if possible during connecting the server and could throw 
`PartitionNotFoundException` or `DataConnectionException` after retry fails.
   
   I already updated the codes in two aspects:
   
   -  Not transform the received `PartitionNotFoundException` on consumer side.
   
   - Send the `PartitionNotFoundException` on producer side in the process of 
creating reader view. If the `ResultPartition` is not removed from 
`ResultPartitionManager`, only the `SpillableSubpartition#createView` might 
throw `IOException` which could indicate the required data file not open 
correctly. So I wrap the `PartitionNotFoundException` in upper layer which 
seems unified for all the `ResultSubpartition` instances besides the  new 
`BoundedBlockingSubpartition` stephan proposed.
   
   After you confirm this way is correct, then I would add new unit tests for 
covering these cases. :) 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to