chunweilei commented on a change in pull request #8266: [FLINK-9904]Allow users to control MaxDirectMemorySize URL: https://github.com/apache/flink/pull/8266#discussion_r282103994
########## File path: flink-dist/src/main/flink-bin/bin/config.sh ########## @@ -429,6 +430,11 @@ if [ -z "${FLINK_TM_NET_BUF_MAX}" -o "${FLINK_TM_NET_BUF_MAX}" = "-1" ]; then FLINK_TM_NET_BUF_MAX=$(parseBytes ${FLINK_TM_NET_BUF_MAX}) fi +# Define FLINK_TM_MAX_OFFHEAP_SIZE if it is not already set +if [ -z "${FLINK_TM_MAX_OFFHEAP_SIZE}" ]; then + # default: Long.MAX_VALUE in TB + FLINK_TM_MAX_OFFHEAP_SIZE=$(readFromConfig ${KEY_TASKM_MAX_OFFHEAP_SIZE} "8388607T" "${YAML_CONF}") Review comment: Should the condition be `if [ -z "${FLINK_TM_MAX_OFFHEAP_SIZE}" -o "${FLINK_TM_MAX_OFFHEAP_SIZE}" = "-1" ]`? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services