bowenli86 commented on a change in pull request #8353: [FLINK-12233][hive]
Support table related operations in HiveCatalog
URL: https://github.com/apache/flink/pull/8353#discussion_r282337775
##########
File path:
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/HiveCatalogBase.java
##########
@@ -89,6 +101,34 @@ private static IMetaStoreClient
getMetastoreClient(HiveConf hiveConf) {
}
}
+ // ------ APIs ------
+
+ /**
+ * Validate input base table.
+ *
+ * @param catalogBaseTable the base table to be validated
+ * @throws IllegalArgumentException thrown if the input base table is
invalid.
+ */
+ protected abstract void validateCatalogBaseTable(CatalogBaseTable
catalogBaseTable)
Review comment:
This would go against the previous suggestion you made:
> Similar to createTable(), I don't see we need to provide implementations
for alterTable() in each subclass because I don't really see much difference.
If validation is different, then we can define a new interface in the base and
have each subclass implement it.
How about leave this as is and refactor if necessary in the future?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
