xuefuz commented on a change in pull request #8353: [FLINK-12233][hive] Support
table related operations in HiveCatalog
URL: https://github.com/apache/flink/pull/8353#discussion_r282711429
##########
File path:
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/GenericHiveMetastoreCatalog.java
##########
@@ -363,4 +332,23 @@ public CatalogColumnStatistics
getPartitionColumnStatistics(ObjectPath tablePath
throw new UnsupportedOperationException();
}
+ // ------ utils ------
+
+ /**
+ * Filter out Hive-created properties, and return Flink-created
properties.
+ */
+ private Map<String, String> retrieveFlinkProperties(Map<String, String>
hiveTableParams) {
Review comment:
The difference is that a static method doesn't require an instance of the
class in order to invoke it. For example, if another static method of this
class needs to call this method, without this one defined as static, one has to
create an instance of the class to invoke the method. The general principle is
that if a method doesn't access any of the object variables/methods, make it
static.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
