[ 
https://issues.apache.org/jira/browse/FLINK-12474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16839230#comment-16839230
 ] 

zhijiang commented on FLINK-12474:
----------------------------------

[~pnowojski] thanks for the confirmation!

Yes, the `SingleInputGate` would be notified by canceler thread after calling 
`SingleInputGate#close()`. But for the case of `UnionInputGate` if the task is 
blocked by `wait()` because of  no available data, I think it has to be wait 
the canceling timeout or I missed other parts to unblock task thread. 

Anyway you could solve this issue in `CheckpointBarrierHandler`, then I could 
close this jira. :)

> UnionInputGate should be notified when closing SingleInputGate by canceler 
> thread
> ---------------------------------------------------------------------------------
>
>                 Key: FLINK-12474
>                 URL: https://issues.apache.org/jira/browse/FLINK-12474
>             Project: Flink
>          Issue Type: Improvement
>          Components: Runtime / Network
>            Reporter: zhijiang
>            Priority: Minor
>
> If task is being canceled, the `SingleInputGate` would be closed by canceler 
> thread. If the `SingleInputGate` is waiting for buffer, 
> `inputChannelWithData` would be notified to wake task thread to exit early. 
> But if the `UnionInputGate` is waiting for buffer, task thread is still 
> stucking in wait when `SingleInputGate` is closed until cancel timeout.
> To make task exit early in this case, we could make `SingleInputGate` further 
> notify `UnionInputGate` after it is closed, then it could also wake task 
> thread to exit during canceling.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to