walterddr commented on a change in pull request #8389: [FLINK-12399][table] Fix
FilterableTableSource does not change after applyPredicate
URL: https://github.com/apache/flink/pull/8389#discussion_r283906054
##########
File path:
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/plan/nodes/logical/FlinkLogicalTableSourceScan.scala
##########
@@ -81,7 +81,13 @@ class FlinkLogicalTableSourceScan(
val terms = super.explainTerms(pw)
.item("fields", tableSource.getTableSchema.getFieldNames.mkString(",
"))
- val sourceDesc = tableSource.explainSource()
+ val auxiliarySourceDesc = tableSource match {
+ case fts: FilterableTableSource[_] =>
+ s"FilterPushDown=${fts.isFilterPushedDown.toString}"
Review comment:
hmm. I think this is valid. I original think since there could only be one
"match" and "onMatch", all the different filters either can be pushed down all
cannot (e.g. always the same set of filter being push down).
but I think yes, there's nothing preventing calcite to choose to partially
push down (not partially possible, but partially push down some of the filter
because of volcano planner thinks it is more efficient than another). I doubt
this is possible at this moment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
