dianfu commented on a change in pull request #8401: [FLINK-12407][python] Add all table operators align Java Table API. URL: https://github.com/apache/flink/pull/8401#discussion_r284618858
########## File path: flink-python/pyflink/table/table_config.py ########## @@ -38,24 +44,76 @@ def is_stream(self, is_stream): @property def parallelism(self): + """ + The parallelism for all operations. + """ return self._parallelism @parallelism.setter def parallelism(self, parallelism): self._parallelism = parallelism + @property + def timezone(self): + """ + The timezone_id for a timezone, either an abbreviation such as "PST", a full name such as + "America/Los_Angeles", or a custom timezone_id such as "GMT-8:00". + """ + return self._j_table_config.getTimeZone().getID() + + @timezone.setter + def timezone(self, timezone_id): + if timezone_id is not None and isinstance(timezone_id, str): Review comment: should also consider unicode ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services