StefanRRichter commented on a change in pull request #8409: [FLINK-12478]
Decompose monolithic run-loops in StreamTask implementa…
URL: https://github.com/apache/flink/pull/8409#discussion_r284665683
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java
##########
@@ -222,12 +222,24 @@ protected StreamTask(
protected abstract void init() throws Exception;
- protected abstract void run() throws Exception;
-
protected abstract void cleanup() throws Exception;
protected abstract void cancelTask() throws Exception;
+ /**
+ * This method implements the default action of the task (e.g.
processing one event from the input). Implementations
+ * should (in general) be non-blocking.
+ *
+ * @return <code>true</code> if there is more work to perform as
default action for this task and <code>false</code>
+ * if the task is ready to finish.
+ * @throws Exception on any problems in the action.
+ */
+ protected abstract boolean performDefaultAction() throws Exception;
Review comment:
It changes the line twice because it is incrementally changed. I see no
problem with that, it is work for different PRs with different purposes. If we
would really decide to merge them, then we should also merge the JIRA tasks,
but I think they are valuable as separated steps.
Even if i had a dummy context, the boolean is still required and the
suggestion would not really help to solve the problem.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
