[ https://issues.apache.org/jira/browse/FLINK-2536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14736493#comment-14736493 ]
ASF GitHub Bot commented on FLINK-2536: --------------------------------------- Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1030#issuecomment-138841521 I think this looks good, except for the comment with the final variable for the lock. One more comment: When concatenating strings, avoid constructs like `" value=" + value.toString()`. Rather do `"value=" + value`. That is safe against null pointers. > Add a retry for SocketClientSink > -------------------------------- > > Key: FLINK-2536 > URL: https://issues.apache.org/jira/browse/FLINK-2536 > Project: Flink > Issue Type: Improvement > Components: Streaming > Affects Versions: 0.10 > Reporter: Huang Wei > Fix For: 0.10 > > Original Estimate: 168h > Remaining Estimate: 168h > > I found the SocketClientSink doesn`t use a re-connect when disconnect from > the socket server or get exception. > I`d like to add a re-connect like socket source for socket sink. -- This message was sent by Atlassian JIRA (v6.3.4#6332)