zentol commented on a change in pull request #8416: [FLINK-12331] Introduce partition/gate setup to decouple task registration with NetworkEnvironment URL: https://github.com/apache/flink/pull/8416#discussion_r284667951
########## File path: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/netty/PartitionRequestClientTest.java ########## @@ -106,15 +106,15 @@ public void testDoublePartitionRequest() throws Exception { final PartitionRequestClient client = new PartitionRequestClient( channel, handler, mock(ConnectionID.class), mock(PartitionRequestClientFactory.class)); - final NetworkBufferPool networkBufferPool = new NetworkBufferPool(10, 32); + final int numExclusiveBuffers = 2; Review comment: variable name no longer makes sense; currently it implies that in the entire pool there are exactly 2 exclusive buffers. Also applies to other instances. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services