WeiZhong94 commented on a change in pull request #8401: [FLINK-12407][python]
Add all table operators align Java Table API.
URL: https://github.com/apache/flink/pull/8401#discussion_r284682569
##########
File path: flink-python/pyflink/table/table_environment.py
##########
@@ -153,9 +240,51 @@ def __init__(self, j_tenv):
self._j_tenv = j_tenv
super(StreamTableEnvironment, self).__init__(j_tenv)
+ def get_config(self):
+ """
+ Returns the table config to define the runtime behavior of the Table
API.
+
+ :return: Current :class:`TableConfig`.
+ """
+ table_config = TableConfig()
+ table_config._j_table_config = self._j_tenv.getConfig()
+ table_config.is_stream = True
Review comment:
I think we'd better keep those set method but set them to private, because
without them we need to put those setters' logic in TableConfig.Builder. I
think it makes more sense to keep these logic in TableConfig.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
