Aitozi commented on issue #8455: [FLINK-12284]Fix the incorrect 
inputBufferUsage metric in credit-based netowork mode
URL: https://github.com/apache/flink/pull/8455#issuecomment-493109896
 
 
   Thanks @zhijiangW for sharing your thoughts on this issue.
   Although the semantics  of `inputBufferUsage` means the buffer occupied by 
`RemoteChannel` which may fill with data or not as you mentioned in 
credit-based mode in the moment,  But I think this PR  taking the exclusive 
buffer into account, which will make the semantics of this more close to the 
original intention.
   I'am also ok to stay the same until the time of introducing new network 
related metrics. I think we are short of more detail metric about credit-based 
network model too.
   Thanks for remind of the PR title format, I will pay more attention to 
this.:)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to