walterddr commented on issue #8324: [FLINK-11921][table] Upgrade to calcite 1.19 URL: https://github.com/apache/flink/pull/8324#issuecomment-493116362 thanks for the pointer @danny0405 actually i agree with the guideline @twalthr setup previously to left the code commented out not removed, and kept the java class in sync with the one used in calcite except for the lines we changed. because 1. commented it out makes it easier for future contributor to maintain the code - I had to dig deep to understand which part of the code is needed to comment out by running multiple tests because that previous removal was not traceable. 2. ideally speaking we shouldn't copy and alter calcite/avatica code, this is only to unblock the release until a specific JIRA has been fix - the previous version of the DateTimeUtils has not been updated since 3,4 versions ago. I think it make sense to upgrade it to the one that currently calcite-core depends on. What do you guys think? I am open up for any changes to the policy as long as we all agree on the process.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
